Merged
Conversation
…o_term_source_types
…o_term_source_types
…o_term_source_types
pascalfleury
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added typing and structure to SdoTermSource.
The various fields of SdoTerm contain either identifiers (as strings), or instances of SdoTerm and the code hacks around this with a lot of obscure casting operations. Replaced the content with an object than contains either, or a sequence which contains either. This makes it possible to at least document the types that are taken by various methods. This also enables, making the code smarter, as most of the current functions systematically assume the worst.