Completition and Examples for WebAPI (#1423)#4674
Completition and Examples for WebAPI (#1423)#4674fthobe wants to merge 19 commits intoschemaorg:mainfrom
Conversation
Backport WebAPI Schema
Based on previous work by @nickevansuk - Replace Google Knowledge Graph API with YouTube API (schemaorg#2635) - Some minor bugfixes to end up with compliant json Closes: schemaorg#1423 Superseedes: schemaorg#2635
|
@nickevansuk can you take a look? I picked up your old PR to complete this. |
|
@MatthiasWiesmann I picked up #2635 to fix the only nit @danbri had back then as the PR was stale for almost a year and required only a minor change. I think this can be merged without issues as it was already approved back then. |
|
@gmackenz should be fine now if nobody complains. |
Adds privacyPolicy to various applicable classes such as Organization, Service and WebAPI Closes schemaorg#3050
Adds privacyPolicy to WebAPI.
There was a problem hiding this comment.
Shouldn't this be "TYPES: #eg-1423 WebAPI"
| </script> | ||
|
|
||
|
|
||
| TYPES: #eg-0464 WebAPI, documentation, termsOfService, apiTransport, conformsTo |
There was a problem hiding this comment.
Why is this "#eg-0464"? I couldn't find any reference to an issue 464?
|
For some reason I forget (maybe @RichardWallis recalls?) we belatedly
decided to give each example an identifier, which were originally assigned
sequentially per
data/examples.txt
There’s a utility under software/ that will add approriage IDs for you.
Somewhere around
https://github.com/schemaorg/schemaorg/blob/main/software/SchemaExamples/README.md
…On Wed, Jan 21, 2026 at 19:50 Gordon Mackenzie ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In data/ext/pending/issue-1423-examples.txt
<#4674 (comment)>:
> "provider": {
***@***.***": "Organization",
"name": "Google Inc."
}
}
</script>
+
+TYPES: #eg-0464 WebAPI, documentation, termsOfService, apiTransport, conformsTo
Why is this "#eg-0464"? I couldn't find any reference to an issue 464?
—
Reply to this email directly, view it on GitHub
<#4674 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJSGJRIWLGR2T2JSAYBFL4H7J6TAVCNFSM6AAAAACQRKA3FKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMOBZGEYTANRTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
An outdated name was used on the organization. Update organization name from 'Google Inc.' to 'Google LLC'
|
Thank you for pitching in :) If the #eg-#### does not serve to indicate an issue anymore, what's the purpose of the progressive number? I can make a PR for the contribution guidelines if they need to be adjusted (at this point they have to). The rakefile does validate the presence of # but nothing else to indicate an issue number. |
|
I believe the similarity to Issue IDs was a coincidence. However we did
have the practice of grouping new terms (and their examples) into files
roughly based on issue IDs. This was never very pure due to the desire to
avoid each vocabulary request being an island decoupled from everything
else. Many issues ended up being reexpressed to exploit or adapt existing
terms. But that is why you’ll see both kinds of ID in the data files.
Also just remembered why we went thru and numbered the examples. It was to
support deeper linking into the documentation using links like
https://schema.org/WebAPI#eg-0239
…while being more robust to changes, additions etc.
…On Wed, Jan 21, 2026 at 20:15 Fab ***@***.***> wrote:
*fthobe* left a comment (schemaorg/schemaorg#4674)
<#4674 (comment)>
@danbri <https://github.com/danbri>
Thank you for pitching in :)
If the #eg-#### does not serve to indicate an issue anymore, what's the
purpose of the progressive number? I can make a PR for the contribution
guidelines if they need to be adjusted (at this point they have to).
—
Reply to this email directly, view it on GitHub
<#4674 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJSGM35VMVLWHFGY5S3VL4H7M7BAVCNFSM6AAAAACQRKA3FKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOOBQHE2TQNJTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@gmackenz there's surely some documentation that has to be written about that (I'd be happy to do it as the contribution guidelines in the current form are at least outdated, in some cases like here flat out wrong). Here's what I can do on the specific PR:
According to (current) docs the issue number would be correct. I'd also open an issue about the docs regarding the identifier. |
Yes please!
Thanks, sounds good to me
Excellent. |
There was a problem hiding this comment.
This is code changes and should be reviewed separately IMO
There was a problem hiding this comment.
I think there are merge conflicts that need to be resolved
Introduction
Building on the work of @nickevansuk this PR completes the work started in PR #2635 by @nickevansuk this PR introduces:
Picking up on the change requests originally raised in #2635 the PR brings following changes:
Addition of Properties
Changes to Examples
Concerns
Closes #1423
Closes #3050
Closes #4697
Renders obsolete: #2635