Skip to content

Completition and Examples for WebAPI (#1423)#4674

Open
fthobe wants to merge 19 commits intoschemaorg:mainfrom
fthobe:1423-WebAPI
Open

Completition and Examples for WebAPI (#1423)#4674
fthobe wants to merge 19 commits intoschemaorg:mainfrom
fthobe:1423-WebAPI

Conversation

@fthobe
Copy link
Contributor

@fthobe fthobe commented Jan 2, 2026

Introduction

Building on the work of @nickevansuk this PR completes the work started in PR #2635 by @nickevansuk this PR introduces:

  • Examples for WebAPI
  • privacyPolicy

Picking up on the change requests originally raised in #2635 the PR brings following changes:

Addition of Properties

  • As Privacy Policies have become a legal requirement on websites to conform with GDPR, the property privacyPolicy has been added to Organization, Service, WebAPI and other classes that seemed appropriate.

Changes to Examples

  • The API provided in the example has been replaced with a currently available API;
  • Fixes minor technical issues such as json syntax errors, bugfixed minor automated testing errors and implemented the changes requested by @gmackenz and @danbri back then.

Concerns

Closes #1423
Closes #3050
Closes #4697
Renders obsolete: #2635

@fthobe
Copy link
Contributor Author

fthobe commented Jan 4, 2026

@nickevansuk can you take a look? I picked up your old PR to complete this.

@fthobe
Copy link
Contributor Author

fthobe commented Jan 15, 2026

@MatthiasWiesmann I picked up #2635 to fix the only nit @danbri had back then as the PR was stale for almost a year and required only a minor change. I think this can be merged without issues as it was already approved back then.

@fthobe fthobe changed the title Samples for WebAPI (#1423) Completition and Examples for WebAPI (#1423) Jan 15, 2026
@fthobe fthobe mentioned this pull request Jan 15, 2026
@fthobe fthobe marked this pull request as draft January 16, 2026 11:38
@fthobe
Copy link
Contributor Author

fthobe commented Jan 17, 2026

@gmackenz should be fine now if nobody complains.

@fthobe fthobe marked this pull request as ready for review January 17, 2026 11:25
Adds privacyPolicy to various applicable classes such as Organization, Service and WebAPI

Closes schemaorg#3050
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "TYPES: #eg-1423 WebAPI"

</script>


TYPES: #eg-0464 WebAPI, documentation, termsOfService, apiTransport, conformsTo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this "#eg-0464"? I couldn't find any reference to an issue 464?

@danbri
Copy link
Contributor

danbri commented Jan 21, 2026 via email

An outdated name was used on the organization.
Update organization name from 'Google Inc.' to 'Google LLC'
@fthobe
Copy link
Contributor Author

fthobe commented Jan 21, 2026

@danbri

Thank you for pitching in :)

If the #eg-#### does not serve to indicate an issue anymore, what's the purpose of the progressive number? I can make a PR for the contribution guidelines if they need to be adjusted (at this point they have to). The rakefile does validate the presence of # but nothing else to indicate an issue number.

@danbri
Copy link
Contributor

danbri commented Jan 21, 2026 via email

@fthobe
Copy link
Contributor Author

fthobe commented Jan 21, 2026

@gmackenz there's surely some documentation that has to be written about that (I'd be happy to do it as the contribution guidelines in the current form are at least outdated, in some cases like here flat out wrong). Here's what I can do on the specific PR:

  • Uniform it to the issue number
  • let the python script run for uniformity

According to (current) docs the issue number would be correct.

I'd also open an issue about the docs regarding the identifier.

@gmackenz
Copy link
Contributor

@gmackenz there's surely some documentation that has to be written about that (I'd be happy to do it as the contribution guidelines in the current form are at least outdated, in some cases like here flat out wrong).

Yes please!

Here's what I can do on the specific PR:

  • Uniform it to the issue number
  • let the python script run for uniformity

According to (current) docs the issue number would be correct.

Thanks, sounds good to me

I'd also open an issue about the docs regarding the identifier.

Excellent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is code changes and should be reviewed separately IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are merge conflicts that need to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy Policy Add "WebAPI" type Outdated syntax in schemaexamples.py

4 participants