Skip to content

Issue #137: Created InteractionCounter type and properties to supersede UserInteraction.#514

Merged
danbri merged 6 commits intoschemaorg:sdo-ganymedefrom
vickitardif:user-interaction
Jun 10, 2015
Merged

Issue #137: Created InteractionCounter type and properties to supersede UserInteraction.#514
danbri merged 6 commits intoschemaorg:sdo-ganymedefrom
vickitardif:user-interaction

Conversation

@vickitardif
Copy link
Contributor

No description provided.

@danbri
Copy link
Contributor

danbri commented May 20, 2015

Thanks @vholland. @elf-pavlik - care to take a look?

@boferri
Copy link

boferri commented May 20, 2015

The term 'interaction' is included in every property and class that is related to this issue, I doubt that this is a best practice for good vocabulary design. Unfortunately, it is obviously necessary to keep everything under the schema.org namespace ... ;)

@danbri
Copy link
Contributor

danbri commented May 20, 2015

@Zazi yes it natural consequence of various design tradeoffs, to drift towards having soft / pseudo namespaces in various places. Although it might not look particularly elegant it does keep several things simpler for publishers/webmasters. I think we can live with it for now.

@elf-pavlik
Copy link
Contributor

@vholland LGTM 😄 thank you!

  1. I wonder why userInteractionCount and not simply interactionCount ?
  2. At some point we still could try to find a way of linking to the collection/container with actual references to all the interactions (e.g. Comment - all the comments, Share - all the shares, Follow - all the followers). In lines of what I tried to brainstorm in this comment replace interactionCount with interaction #137 (comment)

@vickitardif
Copy link
Contributor Author

@elf-pavlik I was going to use interactionCount, but that already exists with different semantics. It seemed confusing to completely change the property's meaning.

If people would rather, I can go back to that name.

@elf-pavlik
Copy link
Contributor

@danbri danbri merged commit 2ce15a7 into schemaorg:sdo-ganymede Jun 10, 2015
@danbri
Copy link
Contributor

danbri commented Jun 10, 2015

Merged in. We have some work on deprecation UI, but the new stuff shows up, e.g. http://webschemas.org/InteractionCounter (also in sdo-ganymede test site)

@vickitardif
Copy link
Contributor Author

SGTM. Feel free to kick back merges back to me.

@unor
Copy link
Contributor

unor commented Jun 11, 2015

Some HTML changes: #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants