Skip to content

added CompoundPriceSpecification#830

Closed
mfhepp wants to merge 35 commits intoschemaorg:sdo-phobosfrom
mfhepp:CompositePricing
Closed

added CompoundPriceSpecification#830
mfhepp wants to merge 35 commits intoschemaorg:sdo-phobosfrom
mfhepp:CompositePricing

Conversation

@mfhepp
Copy link
Contributor

@mfhepp mfhepp commented Oct 2, 2015

This pull requests addresses #829.

It fixes a major inconsistency in the GoodRelations pricing model and is needed for hotels and rental cars.

This was referenced Oct 2, 2015
Closed
Closed
mfhepp added a commit to mfhepp/schemaorg that referenced this pull request Oct 2, 2015
@mfhepp
moved CompoundPriceSpecification and DistanceSpecification further up…
c426268 
… to link to schemaorg#830 and schemaorg#832
@rvguha
Copy link
Contributor

rvguha commented Oct 3, 2015

This might break some of the applications that currently use schema.org
price specification.

Lets please get their ok before making these changes

guha

On Fri, Oct 2, 2015 at 2:16 PM, Martin Hepp [email protected]
wrote:

This pull requests addresses #829
#829.

It fixes a major inconsistency in the GoodRelations pricing model and is

needed for hotels and rental cars.

You can view, comment on, or merge this pull request online at:

#830
Commit Summary

  • added CompoundPriceSpecification

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#830.

@mfhepp
Copy link
Contributor Author

mfhepp commented Oct 3, 2015

Dear Guha:
Of course, it is good to check that it won't break existing apps, but I am pretty sure that there is almost no markup in the wild to far that properly uses multiple price components in the existing form. So the focus of a cross-check should be that an app that currently understands a single UnitPriceSpecification will also be able to consider multiple components attached via the new CompoundPriceSpecification type.

Martin

martin hepp http://www.heppnetz.de
[email protected] @mfhepp

On 03 Oct 2015, at 21:17, R.V.Guha [email protected] wrote:

This might break some of the applications that currently use schema.org
price specification.

Lets please get their ok before making these changes

guha

On Fri, Oct 2, 2015 at 2:16 PM, Martin Hepp [email protected]
wrote:

This pull requests addresses #829
#829.

It fixes a major inconsistency in the GoodRelations pricing model and is

needed for hotels and rental cars.

You can view, comment on, or merge this pull request online at:

#830
Commit Summary

  • added CompoundPriceSpecification

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#830.

—
Reply to this email directly or view it on GitHub.

@rvguha
Copy link
Contributor

rvguha commented Oct 3, 2015

Breaking usage of existing markup is not the only problem. Another problem
that occurs is that new (and some old) publishers start switching to the
new way of expressing things, which old apps cannot (yet) consume.

guha

On Sat, Oct 3, 2015 at 12:32 PM, Martin Hepp [email protected]
wrote:

Dear Guha:
Of course, it is good to check that it won't break existing apps, but I am
pretty sure that there is almost no markup in the wild to far that properly
uses multiple price components in the existing form. So the focus of a
cross-check should be that an app that currently understands a single
UnitPriceSpecification will also be able to consider multiple components
attached via the new CompoundPriceSpecification type.

Martin

martin hepp http://www.heppnetz.de
[email protected] @mfhepp

On 03 Oct 2015, at 21:17, R.V.Guha [email protected] wrote:

This might break some of the applications that currently use schema.org
price specification.

Lets please get their ok before making these changes

guha

On Fri, Oct 2, 2015 at 2:16 PM, Martin Hepp [email protected]
wrote:

This pull requests addresses #829
#829.

It fixes a major inconsistency in the GoodRelations pricing model and
is

needed for hotels and rental cars.

You can view, comment on, or merge this pull request online at:

#830
Commit Summary

  • added CompoundPriceSpecification

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#830.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#830 (comment).

@vickitardif
Copy link
Contributor

vickitardif commented Oct 4, 2015

Do you have examples of this new schema? It is complex, so authors are probably not going to use it correctly with only the definition to go by.

bbdg and others added 22 commits October 15, 2015 21:53
@bbdg
Adding DietaryRestriction enumeration as a property of Recipe.
95a0128
@danbri
Merge pull request schemaorg#872 from schemaorg/sdo-phobos
89b17ec 
Merge sdo-phobos changes into master branch.
@danbri
Post-release activities.
f647e63 
Last notes before we realised that there are problems with
the extensions, and that these notes deal inadequately with that topic.
TODO:
 * testing extensions
 * dealing with screwups: update master and merge back into
   the release branch, for things < 24h after publication.
@danbri
Setup for sdo-deimos
368f4b9
@danbri
Update for current work.
f62e91b
@danbri
Noted new known work-in-progress domain.
6c422aa
@vickitardif
Merge pull request schemaorg#38 from schemaorg/sdo-deimos
963f8cd 
Syncing with sdo-deimos.
examples for LRMI properties
8cc87a5
@danbri
Merge pull request schemaorg#902 from dcmi/sdo-deimos
07ca213 
examples for LRMI properties - fixes schemaorg#912
@danbri
Noted LRMI/education examples (thanks @philbarker). schemaorg#912
0273690
@danbri
double fullstop.
fb38faf
@danbri
Bad link.
9310ace
@danbri
More edu-related terms listed for the LRMI examples.
7e8107d
@danbri
Merge pull request schemaorg#957 from bbdg/RestrictedDiet
c4fef7e 
Adding DietaryRestriction enumeration as a property of Recipe.
@danbri
Added suitableForDiet to examples and release notes.
c44427a 
For schemaorg#845
@danbri
Improved wording of suitableForDiet following schemaorg#845 discussion.
811667b
@danbri
Added "or guideline" following @ekgs1 's suggestion in schemaorg#845.
f87b5b2
Fix (schemaorg#958) Added rdfs:label to embeded RDFa on term pages.
ab0b4eb
@vickitardif
Merge pull request schemaorg#39 from schemaorg/sdo-deimos
916e840 
Syncing with sdo-deimos
@vickitardif
Issue 966: Fixed PropertyValue example in JSON-LD.
fccc167
@danbri
Merge pull request schemaorg#970 from vholland/examples_fix
3d097e4 
Issue schemaorg#966: Fixed PropertyValue example in JSON-LD.
@danbri
noted a todo
bfbc38f
danbri and others added 10 commits January 20, 2016 21:29
@mfhepp mfhepp mentioned this pull request Feb 18, 2016
Closed
@mfhepp mfhepp mentioned this pull request Feb 18, 2016
Merged
@mfhepp
Copy link
Contributor Author

mfhepp commented Feb 18, 2016

I have closed and updated this pull request, see #994 for the correct one.

@mfhepp mfhepp closed this Feb 18, 2016
danbri added a commit that referenced this pull request Mar 18, 2016
@danbri
Merge pull request #994 from mfhepp/CompositePricing
e15f26d 
Composite pricing, updated (supersedes #830)
@alex-jansen alex-jansen mentioned this pull request May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mfhepp @rvguha @vickitardif @bbdg @danbri