Thanks for this. Is there a corresponding issue describing the needs that this implementation addresses? If not could you file something? It is best not to have dangling solutions filed solely as pull requests...

I created a respective issue to manage this work, see #969

Not a full review, but from a first pass: re "LoanOrCredit, InvestmentOrDeposit" ... can you try to come up with a name that doesn't include "Or" in it?

I think the current names are better than using a single super-term. We have to make sure people from the industry find the proper concepts. LoanOrCredit are two common words for such financial products where you get temporary access to an amount of money. We could, if absolutely needed, condense it to "Loan" (see also https://en.wikipedia.org/wiki/Loan).

InvestmentOrDeposit was chosen as an intuitive super-term for all financial products in which the client gives money for a future return. IMO, investment is more natural if the revenues are in the focus, while deposit is more common when the safe repayment of the money is the primary goal. If I deposit money, I want to get it back. If I make an investment, I am mainly looking for earnings from giving away the money.

I support Martin in his description and analysis.

The two super-terms were chosen to support the common properties across
current and future individual financial product types. These naturally
separate into the two product areas he describes for temporary access to
an amount of money and for giving money for future return.

Although logically two classes of products, the financial industry further
subdivide them into loans/credit and investment/deposit products which are
the names they would use when looking for appropriate terms. If in the
real world, actual products cleanly dropped into those 4 categories we may
have had the option to go for four super-types instead of two. However it
is clear that some products exhibit the attributes of investments and deposits for example.

If we were looking at individual types I would share your discomfort at the
proposed naming. As these are proposed as super-types for more specific
individual subtypes I believe they are named appropriately.

~Richard.

On 18 February 2016 at 21:24, Martin Hepp [email protected] wrote:

I think the current names are better than using a single super-term. We
have to make sure people from the industry find the proper concepts.
LoanOrCredit are two common words for such financial products where you get
temporary access to an amount of money. We could, if absolutely needed,
condense it to "Loan" (see also https://en.wikipedia.org/wiki/Loan).

InvestmentOrDeposit was chosen as an intuitive super-term for all
financial products in which the client gives money for a future return.
IMO, investment is more natural if the revenues are in the focus, while
deposit is more common when the safe repayment of the money is the primary
goal. If I deposit money, I want to get it back. If I make an investment, I
am mainly looking for earnings from giving away the money.

—
Reply to this email directly or view it on GitHub
#965 (comment).

Couple of examples of live commercial sites using the terms in this proposal. Both having JSON-LD inserts which I have extracted and attached for reference:

• https://www.bancofcal.com/lending/ - Extract: banclending.txt
• https://www.banchomeloans.com/ - Extract: banchomelones.txt

Git reports conflicts with this PR in its current state.
In terms of the proposed changes it is up to date.
However investigation shows that changes in a part of schema.rdfa are not fully understood by the git merge mechanism, and would need a little manual intervention.

Background to this proposal and links to examples are available on a wiki page in the FIBO W3C Wiki Here: https://www.w3.org/community/fibo/wiki/Main_Page