Merged
Conversation
#1258 中引入了硬编码的暗色 hex 值（#414958/#474747/#333333）和 RGB 文字颜色， 导致脚本列表在亮色模式下也显示为暗色背景。 改用 Arco Design CSS 变量（--color-fill-2, --color-text-2 等），使脚本列表 在亮色/暗色模式下都能正确显示。
Merged
Collaborator
|
你确认那些颜色辨别度足够就行了 ( 我不看了 ） .dark 用 |
Member
Author
最好还是变量了 |
Collaborator
xxx {
--editor-color-1: #xxxxxx;
--editor-color-2: #xxxxxx;
--editor-color-3: #xxxxxx;
}
.dark xxx {
--editor-color-1: #414958;
--editor-color-2: #474747;
--editor-color-3: #333333;
}（我忘了 dark 那個class還是attribute是放哪了。反正就是這個做法） |
Member
Author
这样也行，不过我的想法是直接和arco的复用了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#414958/#474747/#333333）和 RGB 文字颜色，导致脚本列表在亮色模式下也显示为暗色背景--color-fill-2,--color-text-2,--color-text-3,--warning-6），使脚本列表在亮色/暗色模式下都能正确显示opacity替代手动计算 RGBA alpha，简化逻辑Test plan