Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

Resolves #72 support for rebeccapurple#73

Merged
MoOx merged 1 commit intosegmentio:masterfrom
jonathanKingston:master
Jun 23, 2014
Merged

Resolves #72 support for rebeccapurple#73
MoOx merged 1 commit intosegmentio:masterfrom
jonathanKingston:master

Conversation

@jonathanKingston
Copy link
Contributor

No description provided.

@MoOx
Copy link
Contributor

MoOx commented Jun 20, 2014

👍

@ianstormtaylor
Copy link
Contributor

Thanks!

Would be better to add a test to the "features" folder, since that other one is mostly just for throwing big files so that we can be sure they don't fail to be parsed.

@MoOx MoOx added the feature label Jun 21, 2014
@jonathanKingston
Copy link
Contributor Author

Will fix late tomorrow; missed that directory completely. Thank you

@jonathanKingston
Copy link
Contributor Author

@ianstormtaylor let me know if you need further changes; thank you.

@MoOx
Copy link
Contributor

MoOx commented Jun 23, 2014

@jonathanKingston can you squash your commits into one before merging please ? (now I can handle the merge ^^)
Btw, for the feature test, you can just keep the first selector, it's enough to check plugin is correctly used, since your plugin should take care of the entire test suit (& it does).

After that we will be good to merge !

@jonathanKingston
Copy link
Contributor Author

@MoOx ready to merge this time; I slapped my hands as I didn't make a feature branch for the merging. Should be good to go though.
Thanks and congrats on becoming a collaborator.

@MoOx
Copy link
Contributor

MoOx commented Jun 23, 2014

Awesome. Thanks !
I want to release that as 1.1 as soon as @ianstormtaylor give me publish access :) (1.1 will include @import changes too)

MoOx added a commit that referenced this pull request Jun 23, 2014
Resolves #72 support for rebeccapurple
@MoOx MoOx merged commit 2136659 into segmentio:master Jun 23, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants