Fix: remove deleted videos from playlists#108
Merged
alexneamtu merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Videos are soft-deleted (status='deleted') so the ON DELETE CASCADE on playlist_videos never fires. Explicitly delete playlist_videos rows in both single and batch delete handlers.
|
Preview deployed: https://pr-108.app.sendrec.eu |
|
Preview environment cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status = 'deleted'), so theON DELETE CASCADEforeign key onplaylist_videosnever firesDELETE FROM playlist_videosin both single delete and batch delete handlersTest plan
TestDelete_Success— expects playlist_videos cleanupTestDelete_MarksFilePurgedOnSuccess— includes playlist cleanup expectationTestDelete_CleansUpWebcamFile— includes playlist cleanup expectationTestDelete_CleansUpTranscriptFile— includes playlist cleanup expectationTestBatchDelete_Success— expects bulk playlist cleanupTestBatchDelete_PartialOwnership— only cleans up actually deleted video IDs