feat: add SAML 2.0 support for workspace SSO#113
Merged
alexneamtu merged 14 commits intomainfrom Mar 6, 2026
Merged
Conversation
|
Preview deployed: https://pr-113.app.sendrec.eu |
- Use SameSite=None; Secure for SAML state cookie (cross-origin POST) - Add 1MB body size limit on metadata URL fetch - Accept KeyDescriptors with unspecified use attribute (Azure AD compat) - Scan nullable OIDC columns into pointer types in OrgCallback - Add happy-path test for InitiateOrgSSO with SAML config - Add test for unspecified KeyDescriptor use attribute
crewjam/saml requires the AuthnRequest ID to validate the response's InResponseTo attribute. Store the request ID alongside the state in the sso_state cookie (state|requestID format) and pass it to ParseResponse.
|
Preview environment cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SAMLProviderimplements existingProviderinterface (AuthURL/Exchange)crewjam/samllibraryPOST /api/auth/saml/{orgId}/acs) and SP metadata endpoint (GET /api/auth/saml/{orgId}/metadata)organization_sso_configsTest Plan