fix: download content from datalinks with nested folders [PLAT-4489]#590
Conversation
I don't think this is true. The It will return a response in the format of: Note: there is a separate I tried to reproduce the originally described issue and it worked fine with the code on master as far as I can see, unless I am missing something? |
georgi-seqera
left a comment
georgi-seqera
left a comment
There was a problem hiding this comment.
actually, I looked at the originally raised issue again and there seems to be an edge case around empty folders in the Platform API that does return an item representing a "folder" - if there is basically an empty folder without anything in it, so it is a "leaf" in the tree.
{
"items": [
{
"path": "directory/filename1.txt",
"size": 106421
},
{
"path": "directory/subdirectory/filename2.txt",
"size": 106421
},
{
"path": "directory/empty-dir/",
"size": null
}
]
}
So the exact root cause is slightly different, but the fix is effectively the same.
Could you add a test for this, please?
2 participants
Description
https://seqera.atlassian.net/browse/PLAT-4489
browse-treereturns the full recursive tree of a given folder, including empty folders, ex:Folder entries (paths ending with
/) are not downloadable and were causing a "File not found" error. Fix skips them during iteration.