chore: change supported node versions#1011
Merged
Conversation
Member
Author
|
Example run (before this PR) where codecov fails: https://ci.appveyor.com/project/shelljs/shelljs/builds/35951797 |
This adds testing for node v14. This removes testing for node v6 and v7 because codecov breaks on these versions. This omits node v15 because appveyor doesn't seem to support this version. The nodejs org currently supports [10, 12, 14, 15]. This makes a couple minor edits to the check-node-support script for consistency with shelljs/shx#186. This bumps the shx dependency because it seems we're hitting issue #973 on node v14. Test: npm run check-node-support
nfischer
force-pushed
the
chore-node-versions
branch
from
1a305c2 to
5d73b5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 35 35
Lines 1332 1332
=======================================
Hits 1295 1295
Misses 37 37 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds testing for node v14. This removes testing for node v6 and v7
because codecov breaks on these versions. This omits node v15 because
appveyor doesn't seem to support this version. The nodejs org currently
supports [10, 12, 14, 15].
This makes a couple minor edits to the check-node-support script for
consistency with shelljs/shx#186.
Test: npm run check-node-support