Skip to content

Upgrade to .NET8#2

Merged
megahirt merged 1 commit intosillsdev:masterfrom
josephmyers:master
Jun 26, 2024
Merged

Upgrade to .NET8#2
megahirt merged 1 commit intosillsdev:masterfrom
josephmyers:master

Conversation

@josephmyers
Copy link
Collaborator

No description provided.

And fixed a few warnings along the way
@megahirt
Copy link
Contributor

Hi @hatton !

@josephmyers and I did an experiment on the smallest .Net Framework project I could think of (sheetswiper) to upgrade it to .Net 8 Windows Forms. I wanted to check with you first about me merging PRs in this repo and making some changes, including possibly releasing a new sheetswiper. Are you ok with that?

This is mostly an experiment to evaluate the effort and impact of upgrading a project to .Net 8 Windows forms.

@megahirt
Copy link
Contributor

@josephmyers Ideally future PRs should start on a feature branch and not master, even on your own fork. I don't think this can be changed without starting a new PR - but that's not necessary this time around.

Copy link
Contributor

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Joseph!

Love the new streamlined csproj.

@hatton
Copy link
Member

hatton commented Jun 25, 2024

Are you ok with that?

Yes

@megahirt megahirt merged commit a940216 into sillsdev:master Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants