Merged
Conversation
I renamed the enum member EXTERN to EXTERNAL. For consistency, I also renmaed INTERN.
The solution is to define them based on the equivalent rp2040 constants
until I find a way to make it compatible, it is disabled when compling for rp2040. Problem is that SPIClass and SPISettings are not defined, SPI seems to work somewhat differently in rp2040
Member
Author
|
Hmmm... I was actually hoping to put this into a new branch... |
Member
|
Very nice! |
Member
|
For windows users, change of driver needed in some cases. |
Member
|
FYI. 3PWM and 6PWM work out of the box for me, well done! ;D |
Member
Author
|
Hey, I think it could be merged, especially if you tested it :-) |
Member
|
Ok, I am in. It's probably good that it goes out so that we have a bit feedback :D |
Member
|
Just a quick info, since it is a bit related to this PR. I've had to change the So now the enum is; enum Pullup{
USE_INTERN, //!< Use internal pullups
USE_EXTERN //!< Use external pullups
};
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RP2040 aka Raspberry Pico support.
3PWM and 6PWM, tests are ongoing.