fix: better deal with proxy returning proxy headers (in response to cURL's Proxy-Connection header) by shunf4 · Pull Request #698 · simplepie/simplepie

shunf4 · 2021-10-11T06:49:55Z

Some HTTP proxy returns headers like this:

HTTP/1.1 200 Connection established\r\n
Connection: close\r\n
(Other headers...)
\r\n
(Headers and bodies of actual HTTP response)

So the code just detecting "HTTP/1.0 200 Connection established\r\n\r\n" won't work with these proxies.

A better way will be split the payload by \r\n\r\n, skip the first part and keep the remaining parts.

…URL's Proxy-Connection header)

…), which is php7 compatible

mblaney · 2021-11-13T03:25:47Z

ok thanks @shunf4

fix: better deal with proxy returning proxy headers (in response to c…

15eb49a

…URL's Proxy-Connection header)

pull-request-size bot added the size/XS label Oct 11, 2021

fix: in prepareHeaders, save exploded array to a variable before end(…

30f3130

…), which is php7 compatible

pull-request-size bot added size/S and removed size/XS labels Oct 11, 2021

mblaney merged commit ebdd064 into simplepie:master Nov 13, 2021

Provide feedback