Fix an PHP 8 issue with the 1.3 branch#702
Merged
mblaney merged 1 commit intosimplepie:one-dot-threefrom Dec 19, 2021
zero-24:patch-1
Merged
Fix an PHP 8 issue with the 1.3 branch#702mblaney merged 1 commit intosimplepie:one-dot-threefrom zero-24:patch-1
mblaney merged 1 commit intosimplepie:one-dot-threefrom
zero-24:patch-1
Conversation
jtojnar
approved these changes
Nov 26, 2021
Contributor
|
Related to #617, which was included in the 1.5.3 release. |
Member
|
no worries @zero-24 just released 1.3.2 |
Author
|
Thanks @mblaney I have just run composer update but I have got the version 1.3.2-dev in the comments is that expected? (joomla/joomla-cms#36358) |
Contributor
Member
|
yeah my bad fixed the version and released 1.3.3 |
Author
|
No problem thanks for your help @mblaney I have just updated my PR to 1.3.3 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
within Joomla 3 we still have to ship the 1.3 version of simplepie as we are required to still support PHP 5.3 but this version gets the issue patched here when used on PHP 8: joomla/joomla-cms#36120
This change here should fix it. So the question is do you still accept changes to this branch and would do a release of the 1.3 branch?
Thanks