When submitting a pull request

1. Run the linter.

   make lint

2. Run the tests.

   make test

3. Carefully read your diff before submitting a PR.

   • Make sure your diff clearly represents your changes.
   • Make sure your code is easy for reviewers to follow.
   • Can your code review be broken into smaller chunks?
   • Make sure you have PHPUnit tests that cover your changes.

4. Make sure that your changes are very-nearly complete.

   • Small changes/fixes based on feedback are OK.
   • Major changes should be avoided while a PR is open. If you need to make major changes, close the PR, make your changes, and open a new PR once you're ready.

5. In the description, start with an explanation of the change and why you want to make it.

   • Make any relevant documentation easily available for reviewers.

6. Add a list of changes you've made using task list syntax.

   • Things that are complete should have [X].
   • Things that are still incomplete should have [ ].

7. Discuss feedback.

   • The SimplePie NG Core Team has the final say on what gets accepted.
   • Respond to all code review feedback.
   • Respectfully discuss any feedback you disagree with. You may need to bring a better argument to the table to convince us.

8. If you don't understand something, ask.