Skip to content

Locator: add type hints#793

Merged
mblaney merged 1 commit intosimplepie:masterfrom
jtojnar:locator-types
Mar 19, 2023
Merged

Locator: add type hints#793
mblaney merged 1 commit intosimplepie:masterfrom
jtojnar:locator-types

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Feb 18, 2023

Needed for PHPStan level 2 to pass.

DOMXpath::query returns DOMNodeList<DOMNode> but here the XPath query looks for a or link elements so we can be more specific.

Needed for PHPStan level 2 to pass.

`DOMXpath::query` returns `DOMNodeList<DOMNode>` but here the XPath query looks for a or link elements so we can be more specific.
@jtojnar jtojnar mentioned this pull request Mar 18, 2023
@mblaney mblaney merged commit 0dadc1e into simplepie:master Mar 19, 2023
@jtojnar jtojnar deleted the locator-types branch March 19, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants