Gzdecode: Deprecate our gzip implementation#882
Merged
jtojnar merged 1 commit intosimplepie:masterfrom Sep 30, 2024
Merged
Conversation
jtojnar
force-pushed
the
deprecate-gzdecode
branch
from
27d8467 to
ac0847b
Compare
jtojnar
force-pushed
the
deprecate-gzdecode
branch
from
ac0847b to
3683b8b
Compare
Art4
requested changes
Sep 29, 2024
Contributor
Art4
left a comment
Art4
left a comment
There was a problem hiding this comment.
In the CHANGELOG.md we should also add a note in the Changed section that now gzdecode() instead of SimplePie\Gzdecode is used.
PHP supports it natively since 5.4. acaaa76 also started to use it, presumably to fix sites that were incorrectly declaring `deflate` method when they were using `gzip`. And since we require PHP 7.2, and the zlib extension is already mandatory for the `gzinflate` and `gzuncompress` functions, let’s also remove the `funcion_exists` check.
jtojnar
force-pushed
the
deprecate-gzdecode
branch
from
f4de7b6 to
011235b
Compare
Art4
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP supports it natively since 5.4.
acaaa76 also started to use it, presumably to fix sites that were incorrectly declaring
deflatemethod when they were usinggzip.And since we require PHP 7.2, and the zlib extension is already mandatory for the
gzinflateandgzuncompressfunctions, let’s also remove thefuncion_existscheck.