Skip to content

recognize bigint as stringifiable#377

Merged
sindresorhus merged 3 commits intosindresorhus:mainfrom
bug-brain:main
Feb 3, 2024
Merged

recognize bigint as stringifiable#377
sindresorhus merged 3 commits intosindresorhus:mainfrom
bug-brain:main

Conversation

@bug-brain
Copy link
Contributor

This would be a nice feature to prevent some explicit .toString()´ calls before passing an object to stringify`.

@sindresorhus
Copy link
Owner

I'm willing to merge this, but you need to fix the lint issues.

@bug-brain
Copy link
Contributor Author

bug-brain commented Jan 31, 2024

Going for [email protected] would require (edit: shows up as red) using String#replaceAll() instead of String#replace(). For the two usages this would not be breaking but I prefer changing less for this feature because it is technically only a typing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants