Merged
Conversation
This fixes a few (harmless) linter errors that occur while checking `asmap.py` in Bitcoin Core's python linter.
Owner
|
Thanks! The future annotations one really helped with making the mypy annotations here usable. Whether it's available probably depends on the Python version. But if it isn't... the annotations can also just be ignored. |
jonatack
reviewed
May 30, 2022
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Concept ACK, these look to be the same as git diff b499e2d fdfa4c3 in bitcoin/bitcoin PR 24864.
Author
|
This doesn't remove the annotations (nor the future line). I'm kind of divided on that. I fully agree annotations are useful. Would be tempted to just exclude asmap from the linter completely, until we bump the Python version… |
Owner
|
utACK 45496c7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few (harmless) linter errors that occur while checking
asmap.pyin Bitcoin Core's python linter.(submitted here in interest of keeping asmap.py the same in both places)