policy: taproot: check prevout scriptPubKey for P2SH#121
Closed
pinheadmz wants to merge 0 commit intosipa:taprootfrom
Closed
policy: taproot: check prevout scriptPubKey for P2SH#121pinheadmz wants to merge 0 commit intosipa:taprootfrom
pinheadmz wants to merge 0 commit intosipa:taprootfrom
Conversation
|
Yes, I think you're right that checking for |
sipa
force-pushed
the
taproot
branch
9 times, most recently
from
4f72ac9 to
7641c52
Compare
|
Is this fixed by bitcoin#17977 (comment) ? |
Author
|
@jnewbery looks like it -- if you're interested in the test I can rebase so the diff is just that? Or just close. |
Owner
|
Oh, I missed this PR, sorry about that. I think this is fixed, but I'll cherry-pick the test. |
Owner
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses bitcoin#17977 (comment)
Tests the actual previous transaction output scriptPubKey for P2SH before applying taproot standardness checks.
Also adds test for version-1-witness-in-P2SH which is NOT taproot and should not be subject to these standardness checks.
This is a hard case to test, because P2SH is correctly checked in interpreter
VerifyWitnessProgram()and so the test case will be thrown out as non-standard for spending an unknown witness version.To test the test, I wrote a commit pinheadmz@ba1ac81 which bypasses the check in
VerifyWitnessProgram(), allowing the v1-in-P2SH to get caught in policyIsWitnessStandard()which is patched by this PR.I'm not sure if there's a better way to cover this patch because there's (at least) two standardness checks applied.