Conversation
darosior
reviewed
Mar 17, 2022
Contributor
There was a problem hiding this comment.
Code looks good to me, this is much cleaner and probably much more efficient than my previous targets. I did not test them to compare the coverage though.
I think we should get rid of my EDIT: i wrongly assumed #78 had been merged already!miniscript_decode if we have miniscript_script.
|
|
||
| /** Fuzz target that runs TestNode on nodes generated using ConsumeNodeStable. */ | ||
| FUZZ_TARGET_INIT(miniscript_random_stable, initialize_miniscript_random) | ||
| FUZZ_TARGET(miniscript_random_stable) |
Comment on lines
+680
to
+929
| /* Fuzz tests that test parsing from a script, and roundtripping via script. */ | ||
| FUZZ_TARGET(miniscript_script) |
Contributor
There was a problem hiding this comment.
This effectively replaces the The miniscript_decode target we already have?miniscript_decode target isn't in master.
This was referenced Mar 17, 2022
Closed
sipa
force-pushed
the
202202_decodefuzz
branch
2 times, most recently
from
3c25782 to
952d025
Compare
Owner
Author
|
Rebased on new #105. |
sipa
force-pushed
the
202202_decodefuzz
branch
2 times, most recently
from
4006134 to
6065e95
Compare
darosior
reviewed
Apr 13, 2022
darosior
reviewed
Apr 15, 2022
Contributor
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
Apart from the typo in the minscript_string target mentioned above, this looks good to me.
darosior
reviewed
Apr 15, 2022
Owner
Author
|
Rebased on top of merged #105, and also addressed:
|
Contributor
|
ACK c65113d |
sipa
added a commit
that referenced
this pull request
Apr 21, 2022
033238f Modernize code: use std::optional instead of bool/outarg (Pieter Wuille) Pull request description: Built on top of #106. ACKs for top commit: darosior: ACK 033238f Tree-SHA512: c198e0cc6b6596dcbf98004b50ad7b3d3b51be0fd04f776ff184f4b0f4eafb0e3fedb2b3ffce181014f240106c0e6d30840685417123866c15c7dcb1b150f193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #105.
This adds script and string roundtrip fuzz tests, all in the same source file (reusing some logic), and unified the names of the tests: