Skip to content

Bugfix: Status bar does not update when a sheet is presented on Android#281

Merged
marcprux merged 2 commits intoskiptools:mainfrom
fhasse95:Statusbar-Appearance-Bugfix
Jan 11, 2026
Merged

Bugfix: Status bar does not update when a sheet is presented on Android#281
marcprux merged 2 commits intoskiptools:mainfrom
fhasse95:Statusbar-Appearance-Bugfix

Conversation

@fhasse95
Copy link
Contributor

@fhasse95 fhasse95 commented Dec 21, 2025 •
edited
Loading

Currently, when a sheet is presented on Android, the status bar style does not update accordingly. Instead of using black icons / text in light mode and white icons / text in dark mode, the icons always use the light mode variant, making the status bar basically invisible in dark mode.

Steps to Reproduce:

  • Run the "Skip Showcase" app on Android
  • Navigate to "Showcase" => "Sheet" and open any of the examples
  • Switch the system appearance from light to dark mode (or vice versa)
  • Observe the status bar icons
    => The status bar icons always use the light mode variant (dark icons / text) and do not adapt to the system theme ⚡

This PR solves the issue by updating the status bar style of the dialog window that presents the sheet depending on the current system appearance (similar to this PR).

Example (Before):
Before

Example (After):
After

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

@cla-bot cla-bot bot added the cla-signed label Dec 21, 2025
@fhasse95
Copy link
Contributor Author

fhasse95 commented Jan 4, 2026

Hi @marcprux,
any updates on this?

I’m happy to help or make additional adjustments if needed to get this merged :)

@marcprux
Copy link
Member

marcprux commented Jan 4, 2026

Apologies for not following-up on this. This method (similar to the improvement you contributed at skiptools/skipapp-showcase#50) does work, but I wonder if it might be better to use the ModalBottomSheetProperties's isAppearanceLightStatusBars and isAppearanceLightNavigationBars properties (newly introduced in compose-material3 1.4.0), which seems custom-tailored for this particular scenario.

Let us know what you think. If ModalBottomSheetProperties doesn't work for this, then we can go ahead with this change.

@fhasse95
Copy link
Contributor Author

fhasse95 commented Jan 9, 2026

Hi @marcprux,

thanks for your feedback! I looked into this and tried to implement the behavior using the ModalBottomSheetProperties. While this ensured that the status and navigation bars were initialized with the correct appearance, the bars unfortunately did not update correctly when a sheet was already open and the system theme switched from light to dark (or vice versa). At least, I could not get this to work reliably.

Therefore, I suggest sticking with the current solution using the DisposableEffect within the synchronization function, which works as expected in boths scenarios and is similar to the solution in the Skip Showcase repository.

What do you think?

@marcprux marcprux requested a review from aabewhite January 9, 2026 19:12
@marcprux marcprux added compose Limitation of Jetpack Compose or issue with SwiftUI translation appearance Inconsistencies between the expected appearance of components in Jetpack Compose vs. SwiftUI labels Jan 9, 2026
@marcprux
Copy link
Member

marcprux commented Jan 9, 2026

WDYT @aabewhite?

@marcprux marcprux added this to Skip Jan 9, 2026
@marcprux marcprux moved this to Todo in Skip Jan 9, 2026
@marcprux marcprux merged commit ac5fae6 into skiptools:main Jan 11, 2026
2 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Skip Jan 11, 2026
@fhasse95 fhasse95 deleted the Statusbar-Appearance-Bugfix branch January 18, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabewhite aabewhite Awaiting requested review from aabewhite

Assignees

@aabewhite aabewhite

Labels

appearance Inconsistencies between the expected appearance of components in Jetpack Compose vs. SwiftUI cla-signed compose Limitation of Jetpack Compose or issue with SwiftUI translation

Projects

Skip
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhasse95 @marcprux @aabewhite