Fix scrollBehavior in Material3TopAppBarOptions#291
Merged
marcprux merged 1 commit intoskiptools:mainfrom Jan 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #290
The readme documents a way to customize the Material 3 top app bar provided by SkipUI's
NavigationStack.But one of these options is not like the others:
scrollBehaviorrequires coordination between the top app bar and itsColumncontainer, via amodifier.nestedScroll(scrollBehavior.nestedScrollConnection).Prior to this PR, the scroll connection was being passed to the TopAppBar after the default nestedScrollConnection was attached to the column's modifier, failing to connect the user-provided scrollBehavior's nestedScrollConnection to the Column. Now, we're extracting the user-provided scrollBehavior early, so we can pass its nestedScrollConnection to the column.
Skip Pull Request Checklist:
swift test