anchor support for scaleEffect and rotationEffect#302
Merged
marcprux merged 2 commits intoskiptools:mainfrom Jan 17, 2026
Merged
anchor support for scaleEffect and rotationEffect#302marcprux merged 2 commits intoskiptools:mainfrom
marcprux merged 2 commits intoskiptools:mainfrom
Conversation
Current state: Works but anchor is ignored Change: Use graphicsLayer with TransformOrigin instead of Modifier.scale() or Modifier.rotate()
Member
|
This will be great! One request: can you convert this PR to a "draft" until it is working and ready for review? |
Contributor
Author
|
Do you mean when the workflow tests pass? except for this empty test always |
Contributor
Author
|
Complement to skiptools/skipapp-showcase-fuse#36 |
Member
|
Oh, I see. I interpreted "Works but anchor is ignored" as meaning that you were going to try getting it working :) No problem. Can you update the Lines 1919 to 1931 in 23672af |
Contributor
Author
|
Ahh, nvm I just worded it badly. "Current state" means pre-commit. Anchor works now, I'll update the readme |
Member
|
Another great contribution! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous state: Worked but anchor was ignored
Change: Use graphicsLayer with TransformOrigin instead of Modifier.scale() or Modifier.rotate()
Edited: Fixed wording
swift test