Lazy containers: Clear contentPadding from environment as we apply it#335
Merged
marcprux merged 1 commit intoskiptools:mainfrom Feb 14, 2026
Merged
Conversation
`PaddingModifier` doesn't apply normal padding to lazy containers (which apply their own scroll container), but instead it adds the padding to a `contentPadding` environment variable, which the lazy containers pass to their Android implementations. But, when we do that, we then need to set the contentPadding to 0,0,0,0, or else any lazy container nested inside a lazy container will find `contentPadding` in the environment and incorrectly apply it again. Fixes skiptools#334
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaddingModifierdoesn't apply normal padding to lazy containers (which apply their own scroll container), but instead it adds the padding to acontentPaddingenvironment variable, which the lazy containers pass to their Android implementations.But, when we do that, we then need to set the contentPadding to 0,0,0,0, or else any lazy container nested inside a lazy container will find
contentPaddingin the environment and incorrectly apply it again.Fixes #334
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Skip Pull Request Checklist:
swift test