Add support for Color(.systemBackground)#347
Merged
marcprux merged 3 commits intoskiptools:mainfrom Mar 5, 2026
Merged
Conversation
`Color.systemBackground` sounds too much like `UIColor.systemBackground`, but `UIColor.systemBackground` actually `Color.background`. `Color.systemBackground` is defined as a synonym for `systemBarBackground`, and it's only used in one place in `List.swift`, so I've updated `List.swift` to use `Color.systemBarBackground` and removed the confusingly named `Color.systemBackground`.
5 tasks
Member
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #278
While I was in there, I removed the confusingly named
Color.systemBackground, which was nothing likeUIColor.systemBackground; it was a grey color set tosystemBarBackground. (I updated the only caller to useColor.systemBarBackground.)Skip Pull Request Checklist:
swift testAdd support for
Color(.systemBackground)skip-fuse-ui#92Add
Color(.systemBackground)skipapp-showcase#68Add
Color(.systemBackground)skipapp-showcase-fuse#48I did the first two commits by hand, and let Cursor Kimi 2.5 do the Fuse support, which I tested in Fuse Showcase.