Add SkipWebUIDelegate popup handling API and docs (#1)#35
Merged
marcprux merged 1 commit intoskiptools:mainfrom Feb 20, 2026
Merged
Add SkipWebUIDelegate popup handling API and docs (#1)#35marcprux merged 1 commit intoskiptools:mainfrom
marcprux merged 1 commit intoskiptools:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added SkipWebUIDelegate as a cross-platform popup/window delegate (WebEngineConfiguration.uiDelegate) to control child-window creation and lifecycle. The delegate exposes:
-webView(:createWebViewWith:platformContext:) -> WebEngine? to allow/deny popup creation by returning a child engine or nil. platformContext is platform-typed (WebKitCreateWindowParams on iOS, AndroidCreateWindowParams on Android) so apps can use native popup details while keeping one shared API.
-webViewDidClose(: child: ) to notify when a child window is closed.
Soft-deprecated pageURL (String?) in favor of url (URL?) to more closely mirror the WKWebView
Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.
Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.
Skip Pull Request Checklist:
swift testCodex generated the code under supervision. Code was reviewed + tested from a sandbox app