Skip to content

Add SkipWebUIDelegate popup handling API and docs (#1)#35

Merged
marcprux merged 1 commit intoskiptools:mainfrom
tifroz:main
Feb 20, 2026
Merged

Add SkipWebUIDelegate popup handling API and docs (#1)#35
marcprux merged 1 commit intoskiptools:mainfrom
tifroz:main

Conversation

@tifroz
Copy link
Contributor

@tifroz tifroz commented Feb 19, 2026

Added SkipWebUIDelegate as a cross-platform popup/window delegate (WebEngineConfiguration.uiDelegate) to control child-window creation and lifecycle. The delegate exposes:

-webView(:createWebViewWith:platformContext:) -> WebEngine? to allow/deny popup creation by returning a child engine or nil. platformContext is platform-typed (WebKitCreateWindowParams on iOS, AndroidCreateWindowParams on Android) so apps can use native popup details while keeping one shared API.
-webViewDidClose(
: child: ) to notify when a child window is closed.

Soft-deprecated pageURL (String?) in favor of url (URL?) to more closely mirror the WKWebView

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Skip Pull Request Checklist:

  • [ x] REQUIRED: I have signed the Contributor Agreement
  • [x ] REQUIRED: I have tested my change locally with swift test
  • [ x] OPTIONAL: I have tested my change on an iOS simulator or device
  • [ x] OPTIONAL: I have tested my change on an Android emulator or device

  • [ x] AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Codex generated the code under supervision. Code was reviewed + tested from a sandbox app

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants