Fix for pybind version >= 2.8.1#216
Merged
hugtalbot merged 1 commit intosofa-framework:masterfrom Dec 1, 2021
Merged
Conversation
guparan
pushed a commit
that referenced
this pull request
Mar 7, 2022
Fix for pybind version >= 2.8.1
guparan
pushed a commit
that referenced
this pull request
Mar 7, 2022
Fix for pybind version >= 2.8.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the version 2.8.1, pybind is doing the binding on attributeError automatically.
(pybind/pybind11@78ee782)
It will be throw a compilation error in SofaPython3 because it was also bind here and there (
already definederror)This PR creates a macro (to avoid copy-paste) which, according to the version of pybind, bind or not the attribute_error.
I am also wondering if it was really necessary to do it in each binding_module (and PythonFactory.cpp) and why not once for all in the PythonFactory.h ?