Simplify UNION and DIFFERENCE boolean operations.#484
Merged
whitequark merged 2 commits intosolvespace:masterfrom Nov 23, 2019
Merged
Simplify UNION and DIFFERENCE boolean operations.#484whitequark merged 2 commits intosolvespace:masterfrom
whitequark merged 2 commits intosolvespace:masterfrom
Conversation
Union and difference are optimized by replacing the expression (!inShell && !inFace) which is equivqlent to (!inShell && !inSame && !inOpp) with outSide which is qeuivalent, since SShell::Class::OUTSIDE is the only remaining possibility.
Contributor
|
Thank you! |
Member
Author
|
Thank you! For maintaining this beautiful project. I still need to go back to the NURBS code and really figure it out in order to make intersections work without hacks. And then perhaps start fixing boolean problems... but the code is complicated and... life happens :-) |
Contributor
|
Totally understandable. Life happens over here too... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Union and difference are optimized by replacing the expression
(!inShell && !inFace)which is equivqlent to
(!inShell && !inSame && !inOpp)with
outSidewhich is qeuivalent, since
SShell::Class::OUTSIDEis the only remaining possibility.