Better helical triangulation #489 and #550 fixed.#643
Merged
phkahler merged 1 commit intosolvespace:masterfrom Jul 11, 2020
Merged
Better helical triangulation #489 and #550 fixed.#643phkahler merged 1 commit intosolvespace:masterfrom
phkahler merged 1 commit intosolvespace:masterfrom
Conversation
Member
Author
|
I want to hold off on this a bit more. Sorry for going too fast. |
Contributor
|
Take all the time you need! There's no harm in having half-done pull requests (it may even help a bit by showing who works on what, and perhaps inspiring collaboration). |
Resolve issue solvespace#489 helix has stairsteps. Force helix axis line to 8 segments. Grid triangulation to use a minimum of 4 segments for degree>1. Adds twist dependence for grid triangulation with degree=1. Added a max_dt parameter for PWL creation and use that for helical edges.
Member
Author
|
@whitequark this seems to fix #550 as well. If you're OK with it I am. |
phkahler
changed the title
phkahler
changed the title
phkahler
changed the title
phkahler
changed the title
This was
linked to
issues
Jul 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…4 segments and forcing grid triangulation to use a minimum of 4x4 quads. This helps with issue #489. Also add a max_dt parameter for PWL creation and use that for helical edges.