Fix issue174 if selection for dragging is not in a previous group, us…#658
Fix issue174 if selection for dragging is not in a previous group, us…#658phkahler wants to merge 1 commit intosolvespace:masterfrom
Conversation
|
I can squash those if you want. Having drags fail because it tried to select something from group zero has been very annoying for me, hence the second commit. |
|
Thanks for the fix! I'm going to need to look closer into it. |
…e chooseFromHoverToSelect to select for dragging.
|
@whitequark can we merge this? It really does fix this problem, and it doesn't touch code for selection or hovering at all. All it does is prevent the new rules for dragging earlier groups from applying the same (first in the list) alternate logic to the current group. I'm still thinking about ways to solve the other dragging related issue. |
|
Sorry, I still haven't found the time to look at this. I'm currently on vacation until the end of the next week, so I'll take a look around then. (Yes, I know I answered to some issues... old habits die slowly) |
|
Closing as superseded by #672. |
2 participants
This needs some testing and it seems like the logic could maybe be simpler.
I figured the reason ChooseFromHoverToDrag() exists is to allow dragging entites from previous groups which doesn't happen with ChooseFromHoverToSelect(). If that's the case, we can just check if the drag selection found something from a previous group. If so use it, otherwise use the selection logic for dragging.