Skip to content

Benchmarks in CI#843

Closed
vespakoen wants to merge 1 commit intosolvespace:masterfrom
vespakoen:bench-ci
Closed

Benchmarks in CI#843
vespakoen wants to merge 1 commit intosolvespace:masterfrom
vespakoen:bench-ci

Conversation

@vespakoen
Copy link
Contributor

No description provided.

@vespakoen vespakoen force-pushed the bench-ci branch 8 times, most recently from a7c5cf8 to 10cc3f5 Compare December 8, 2020 23:47
@phkahler
Copy link
Member

phkahler commented Dec 9, 2020

What is this?
It looks like you're making OpenMP unconditional for release - we do with and without for windows.
Don't really want to run benchmarks on the CI system do we?

@vespakoen
Copy link
Contributor Author

I just added a Debug / Release mode to the build-ubuntu script, nothing OpenMP related got changed.
It also looks like my editor formatted the whole .yml file...

I think it would actually be pretty cool to run benchmarks in CI, it allows us to see which PR's speed things up or slow things down.
Right now it doesn't store the results anywhere so it's not that valuable yet because results cannot easily be compared.

@phkahler
Copy link
Member

phkahler commented Dec 9, 2020

We have no idea what hardware the CI is running on, if it's shared, weather it's the same as last time, etc... Benchmarking should always be done locally.

@vespakoen
Copy link
Contributor Author

Allright, closing this.

@vespakoen vespakoen closed this Dec 9, 2020
@ruevs ruevs mentioned this pull request Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants