You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is this?
It looks like you're making OpenMP unconditional for release - we do with and without for windows.
Don't really want to run benchmarks on the CI system do we?
I just added a Debug / Release mode to the build-ubuntu script, nothing OpenMP related got changed.
It also looks like my editor formatted the whole .yml file...
I think it would actually be pretty cool to run benchmarks in CI, it allows us to see which PR's speed things up or slow things down.
Right now it doesn't store the results anywhere so it's not that valuable yet because results cannot easily be compared.
We have no idea what hardware the CI is running on, if it's shared, weather it's the same as last time, etc... Benchmarking should always be done locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.