Skip to content

feat: add JumpCloud as identity provider for SSO#997

Merged
msukkari merged 2 commits intomainfrom
msukkari/add-jumpcloud-sso
Mar 12, 2026
Merged

feat: add JumpCloud as identity provider for SSO#997
msukkari merged 2 commits intomainfrom
msukkari/add-jumpcloud-sso

Conversation

@msukkari
Copy link
Contributor

@msukkari msukkari commented Mar 12, 2026

Summary

Adds JumpCloud as an OIDC identity provider option for SSO authentication. JumpCloud integrates with the existing IdP system following the same pattern as Okta, Keycloak, and Authentik.

Changes

  • Schema definition for JumpCloudIdentityProviderConfig (clientId, clientSecret, issuer)
  • SSO provider registration using generic OIDC provider configuration
  • UI integration with logo and analytics tracking
  • Complete documentation with setup instructions

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features

  • JumpCloud SSO Support - JumpCloud is now available as an identity provider for single sign-on (SSO) authentication. Configuration includes OIDC-based setup with support for environment variables or Google Cloud Secrets for credential management.

msukkari and others added 2 commits March 12, 2026 09:33
Adds support for JumpCloud as an OIDC identity provider, enabling SSO authentication. Includes schema definition, SSO provider registration, UI components, analytics tracking, logo, and documentation.

Co-Authored-By: Claude Haiku 4.5 <[email protected]>
@github-actions

This comment has been minimized.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 159aade8-883d-4c48-b442-9842dbe66c64

📥 Commits

Reviewing files that changed from the base of the PR and between 1ce1ec8 and 16c7710.

⛔ Files ignored due to path filters (1)
  • packages/web/public/jumpcloud.svg is excluded by !**/*.svg
📒 Files selected for processing (13)
  • CHANGELOG.md
  • docs/docs/configuration/idp.mdx
  • docs/snippets/schemas/v3/identityProvider.schema.mdx
  • docs/snippets/schemas/v3/index.schema.mdx
  • packages/schemas/src/v3/identityProvider.schema.ts
  • packages/schemas/src/v3/identityProvider.type.ts
  • packages/schemas/src/v3/index.schema.ts
  • packages/schemas/src/v3/index.type.ts
  • packages/web/src/app/login/components/loginForm.tsx
  • packages/web/src/ee/features/sso/sso.ts
  • packages/web/src/lib/posthogEvents.ts
  • packages/web/src/lib/utils.ts
  • schemas/v3/identityProvider.json

Walkthrough

Adds JumpCloud as a new OIDC-based identity provider for SSO authentication. Changes include schema and type definitions, documentation, analytics event tracking, and integration into the SSO provider initialization flow.

Changes

Cohort / File(s) Summary
Documentation & Changelog
CHANGELOG.md, docs/docs/configuration/idp.mdx
Added changelog entry and new JumpCloud provider documentation with OIDC setup instructions and configuration examples.
Schema Definitions
docs/snippets/schemas/v3/identityProvider.schema.mdx, docs/snippets/schemas/v3/index.schema.mdx, packages/schemas/src/v3/identityProvider.schema.ts, packages/schemas/src/v3/index.schema.ts, schemas/v3/identityProvider.json
Introduced JumpCloudIdentityProviderConfig schema supporting clientId, clientSecret, and issuer fields with env-based or Google Cloud Secret credentials.
Type Definitions
packages/schemas/src/v3/identityProvider.type.ts, packages/schemas/src/v3/index.type.ts
Added JumpCloudIdentityProviderConfig interface and integrated into IdentityProviderConfig union type.
SSO & Login Integration
packages/web/src/ee/features/sso/sso.ts, packages/web/src/app/login/components/loginForm.tsx, packages/web/src/lib/utils.ts
Implemented JumpCloud provider initialization in SSO flow, added analytics event mapping for JumpCloud login, and configured provider display info with logo.
Analytics Events
packages/web/src/lib/posthogEvents.ts
Added new PosthogEventMap entry for wa_login_with_jumpcloud event type.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: add JumpCloud as identity provider for SSO' accurately and concisely describes the main change: adding JumpCloud as a new identity provider for SSO authentication.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch msukkari/add-jumpcloud-sso
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msukkari
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@msukkari msukkari merged commit 636e493 into main Mar 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant