packages/backend/src/bitbucket.ts (2)

793-797: Consider logging when the probe is skipped due to missing identifiers.

When projectKey or repoSlug is missing, the function silently returns false, treating it as if public access is disabled. While defaulting to the safer assumption is appropriate, logging a warning here would help diagnose unexpected behavior if a repo from the API has malformed data.

🔧 Suggested improvement

     const projectKey = publicRepo.project?.key;
     const repoSlug = publicRepo.slug;
     if (!projectKey || !repoSlug) {
+        logger.warn(`Cannot probe public access: repo missing projectKey or repoSlug`);
         return false;
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/backend/src/bitbucket.ts` around lines 793 - 797, When projectKey or
repoSlug extracted from publicRepo are missing, add a warning log before
returning false: log which identifier is missing and include identifying context
from publicRepo (e.g., publicRepo.id, publicRepo.name or the raw object) so
callers can diagnose malformed API data; implement this in the same block
handling projectKey/repoSlug (use the existing logger instance such as logger or
processLogger), then return false as before.

---

800-805: Consider adding a timeout to the probe request.

The unauthenticated fetch has no explicit timeout. If the server is slow or unresponsive, this could delay the entire connection sync. Consider adding an AbortSignal with a reasonable timeout (e.g., 10-30 seconds).

🔧 Suggested improvement

+    const PROBE_TIMEOUT_MS = 15000;
     const url = `${serverUrl}/rest/api/1.0/projects/${projectKey}/repos/${repoSlug}`;
     try {
         const response = await fetch(url, {
             headers: { Accept: 'application/json' },
             // Intentionally no Authorization header - we want to test anonymous access
+            signal: AbortSignal.timeout(PROBE_TIMEOUT_MS),
         });
         return response.ok;
     } catch (e) {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/backend/src/bitbucket.ts` around lines 800 - 805, The anonymous
probe fetch currently has no timeout and can hang; wrap the request in an
AbortController with a short timeout (e.g., 10–30s), pass controller.signal to
fetch, and clear the timeout after the response is received. Locate the try
block that calls fetch(url, { headers: { Accept: 'application/json' } }) (the
anonymous probe returning response.ok) and add the AbortController logic and a
setTimeout that calls controller.abort(), and ensure any abort errors are
handled so the function returns false or propagates a controlled error as
appropriate.