Skip to content

Improve ResourceHttpMessageConverter target type support #36368

New issue
New issue
Closed
Closed
Improve ResourceHttpMessageConverter target type support#36368
Assignees
bclozel
Labels
in: webIssues in web modules (web, webmvc, webflux, websocket)type: enhancementA general enhancement
Milestone
7.0.6
@sparecycles

Description

@sparecycles
sparecycles
opened on Feb 22, 2026

Not an issue. Just noticed while digging through the implementation: Looks like the ResourceHttpMessageConverter can construct a value that doesn't implement the requested type if that type extends the non-final ByteArrayResource type.

spring-framework/spring-web/src/main/java/org/springframework/http/converter/ResourceHttpMessageConverter.java

Lines 96 to 104 in 2691489

else if (Resource.class == clazz || ByteArrayResource.class.isAssignableFrom(clazz)) {
byte[] body = StreamUtils.copyToByteArray(inputMessage.getBody());
return new ByteArrayResource(body) {
@Override
public @Nullable String getFilename() {
return inputMessage.getHeaders().getContentDisposition().getFilename();
}
};
}

the condition should probably be

 else if (Resource.class == clazz || clazz.isAssignableFrom(ByteArrayResource.class)) {

which I guess could then be simplified to

 else if (clazz.isAssignableFrom(ByteArrayResource.class)) {

(but maybe this simplification would be a de-optimization if clazz == Resource.class is a common case).

Metadata

Metadata

Assignees

Labels

in: webIssues in web modules (web, webmvc, webflux, websocket)type: enhancementA general enhancement

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions