Add programmatic configuration tabs in the transactional refdoc#36323
Closed
jisub-dev wants to merge 1 commit intospring-projects:mainfrom
Closed
Add programmatic configuration tabs in the transactional refdoc#36323jisub-dev wants to merge 1 commit intospring-projects:mainfrom
jisub-dev wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
sdeleuze
requested changes
Feb 15, 2026
Contributor
sdeleuze
left a comment
sdeleuze
left a comment
There was a problem hiding this comment.
That a good start, please take in account my comments.
Also, there are more samples in this section where a similar update would make sense, could you please handle them as well?
framework-docs/modules/ROOT/pages/data-access/transaction/declarative/annotations.adoc
Show resolved
Hide resolved
framework-docs/modules/ROOT/pages/data-access/transaction/declarative/annotations.adoc
Outdated
Show resolved
Hide resolved
sdeleuze
added
in: data
sdeleuze
changed the title
- Extract code examples to separate Java, Kotlin, and XML files - Add Kotlin configuration sample alongside Java - Change "Java Config" terminology to "Programmatic Configuration" - Use include-code directive for better maintainability Addresses review feedback in spring-projectsgh-36323 Signed-off-by: jisub-dev <[email protected]>
jisub-dev
force-pushed
the
docs/transaction-java-config
branch
from
78a69c0 to
ce3ef46
Compare
|
is this issue still valid? |
Contributor
|
I think it is, I was on PTO, I will review and potentially merge it shortly. |
|
sure look at it and lmk if you need help with anything |
sdeleuze
pushed a commit
to sdeleuze/spring-framework
that referenced
this pull request
Mar 9, 2026
- Extract code examples to separate Java, Kotlin, and XML files - Add Kotlin configuration sample alongside Java - Change "Java Config" terminology to "Programmatic Configuration" - Use include-code directive for better maintainability See spring-projectsgh-36323 Signed-off-by: jisub-dev <[email protected]>
Contributor
|
@jisub-dev Reworked and merged, next time please check your contribution before sending it, it was broken in several ways. |
Contributor
Author
|
Thanks for the review, and for reworking and merging this. I’ll double-check my changes more carefully before submitting next time. |
sbrannen
added a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Java Config example alongside existing XML configuration in the
@Transactionalannotations section.
Changes:
@EnableTransactionManagementsetupThis allows users to choose between modern Java Config and traditional XML
configuration.
Closes #34093