Conversation
rearrange preferences database: * skip advanced button * allways show editDatabaseDefaultSqlText and its label * use complete southern dialogspace for sql edit widget
mgrojo
requested changes
May 16, 2020
fix ui mistake (reset currenIndex to 0)
MKleusberg
requested changes
May 19, 2020
Member
MKleusberg
left a comment
MKleusberg
left a comment
There was a problem hiding this comment.
I fully agree with your changes here, @horst-p-w-neubauer. I have just one minor thing you might want to change. But other than that this looks good 👍
done: fix ui mistake (4x XyMargin)
Member
|
This seems ready to merge. |
Member
|
I'm going to start merging outstanding changes for the 3.12.x branch today or tomorrow, then push out a "release candidate v1 build". Is this something we should try to included? |
Member
|
It should be safe to include it. Unless it generates conflicts, it can be included. |
Member
|
Awesome, thanks @mgrojo. 😄 |
justinclift
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rearrange preferences database: