Qt Function Obsolescence#2287
Qt Function Obsolescence#2287justinclift merged 1 commit intosqlitebrowser:masterfrom scottfurry:obsoleteFNs
Conversation
During a build with all warnings enabled, compiler reported numerous Qt Functions as being obsolete. Review of the used functions, these functions have been marked as obsolete as far back as Qt-5.12.x series. Obsolete functions involved the use of Foreground/Background colour setting. API description showing obsolete functions: https://doc.qt.io/qt-5/qlistwidgetitem-obsolete.html https://doc.qt.io/qt-5/qtreewidgetitem-obsolete.html
|
As a data point, although the Win and macOS builds we create use Qt 5.12, the various Linux distributions that compile and include DB4S sometimes use much older Qt releases. I think the oldest general release whose userbase still uses DB4S is probably CentOS 7. That would be a reasonable choice to check what Qt version is in use. 😄 |
And that's a rational point. I tried to trace, similar to my last PR about obsolete functions, where the change occurred to see if that version specificity should be incorporated. Qt API docs did not make this distinction. The 5.15.x, 5.14.x and 5.12.x branches all show the functions in question as obsolete for that Qt version. |
|
No worries. We can spin up a CentOS 7 VM and see if it compiles ok after applying the commits from this PR. 😄 |
|
Repology reports that CentOS 7 is at 5.9.x branch. I think we'll be okay here. I want to be hopeful. |
|
No worries. Lets merge this then, and see how it goes. 😄 |
2 participants
During a build with all warnings enabled, compiler reported numerous
Qt Functions as being obsolete. Review of the used functions, these
functions have been marked as obsolete as far back as Qt-5.12.x series.
Obsolete functions involved the use of Foreground/Background colour setting.
API description showing obsolete functions:
https://doc.qt.io/qt-5/qlistwidgetitem-obsolete.html
https://doc.qt.io/qt-5/qtreewidgetitem-obsolete.html