Move recent files item to new context menu and add clear recent file function#2347
Move recent files item to new context menu and add clear recent file function#2347mgrojo merged 11 commits intosqlitebrowser:masterfrom lucydodo:dev-recent_file_menus
Conversation
Declare a method prototype to handle the newly added menu item. and delete divider(QAction *recentSeparatorAct) because that is no longer used.
Implement method that delete recent file list by newly added menu item. and delete divider(QAction *recentSeparatorAct) because that is no longer used.
|
Seems like a reasonable idea. 😄 Btw, there's a typo in your description of the PR: The source code doesn't have the typo though. 😉 |
|
I just fixed it. Thank you! |
|
May I close the issue without further discussion? |
|
Technically yes. First through, it's probably a better idea to let people know why you want to close it, just in case there's a better way. 😄 |
|
There is no particular reason to close it. I will keep it for the time being for further better comments. :D |
|
@mgrojo I have modified the code according to your review. |
|
@lucydodo Nice work! It's now squashed and merged. Thank you! The list of recent files is now in line with current standards and it doesn't make the File menu so wide. Maybe we could increase now the number of recent files to 9, for example. |
|
@mgrojo Thank you for merge, I couldn't be happier about it! |
I simply meant to increase the value of MaxRecentFiles to get more entries in the list, but you are free to implement a preference for that. |
3 participants
Recently used files in DB4S were previously displayed at the bottom of the file menu.
However, I've implemented this idea because I thought it would be better to create a menu called Recent Files in the File menu, and access the recent files in it and delete the list if necessary.
and also, I'm ready to listen to any advice. This is because I'm NOT sure about the QT framework and I'm afraid about requesting this PR without knowing the atmosphere of the DB4S team to see if it is okay to send a contribution to the implementation of the function. I wait for your valuable advice or feedback. Thanks!
Known bugs
Test Environment