Avoid attaching the plot when the signal is notifying the row count#2368
Avoid attaching the plot when the signal is notifying the row count#2368MKleusberg merged 1 commit intomasterfrom
Conversation
since the data wouldn't be available yet. See issue #2286
|
I open this pull request, because there could be a better solution, which might imply refactoring in the signals emitted by the SqliteTableModel class. |
|
Cool. This seems like it would have been super annoying to track down. 😄 |
|
Thanks, @mgrojo! As Justin says, this must have been awful to track down. I think this solution is the best for now. We could think about moving the |
|
@mgrojo @MKleusberg Should this be merged into 3.12.1 as well? |
|
Yes, good point! This bug was introduced in 1f9101a so it is present in 3.12.0. |
Thanks. I tried some changes in the connection or emission of signals (not sure about that specific case though), and they either gave other problems, or did not solve the issue). We should take a look again when we have to change something related to that code. |
Yeah, I agree 👍 |
since the data wouldn't be available yet.
See issue #2286