Install SVG logo as hicolor scalable icon#2431
Merged
mgrojo merged 1 commit intosqlitebrowser:masterfrom Oct 10, 2020
pinotree:install-svg-icon
Merged
Install SVG logo as hicolor scalable icon#2431mgrojo merged 1 commit intosqlitebrowser:masterfrom pinotree:install-svg-icon
mgrojo merged 1 commit intosqlitebrowser:masterfrom
pinotree:install-svg-icon
Conversation
Install the SVG logo as scalable icon in the global hicolor icon theme: this way, application launchers/browsers that show icons bigger than 256 pixels can show a good-looking icon from the SVG logo instead of upscaling the 256px PNG icon.
Member
|
Thanks @pinotree, this seems like a good idea. 😄 |
Member
|
Thanks for the contribution, @pinotree! |
Contributor
|
When we did PR for #2270, we only handled the icon files. The assumption there was that application icon was to be taken from the Recommend correcting pull to match past assumptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the SVG logo as scalable icon in the global hicolor icon theme: this way, application launchers/browsers that show icons bigger than 256 pixels can show a good-looking icon from the SVG logo instead of upscaling the 256px PNG icon.