Refresh all new table browser tabs#2751
Merged
mgrojo merged 1 commit intosqlitebrowser:masterfrom Jun 24, 2021
Merged
Conversation
MainWindow::newTableBrowserTab is only calling the new TableBrowser's refresh() method through the constructor, before it has its model set, and the browser therefore is still blank when the user first sees it. A manual refresh at the end seems to be one way to fix this.
Member
|
Sounds like a good idea to me. We'll need one of our more proper developers (eg knows the source code) to review this though. 😄 |
Member
|
Not sure if we should refactor some of the code related to tabs in the data browser, but in any case, this fixes the bug, so I'll merge it without further thoughts. Thanks for taking the time to analyse it and provide a patch, @oldlaptop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new multi-tab layout post-3.12.2 has the "Browse Table" context menu option for tables in the Database Structure browser create a new tab for the table, but it does not refresh the newly-created TableBrowser object (outside its constructor, where it doesn't have its model set yet) before it's displayed.
This means the user sees a blank table, and has to manually refresh the view. Since it appears as though the table's empty, this can be confusing, especially if the database happens to have the occasional genuinely-empty table in it. I'm not sure of the correct way to fix this, but this patch certainly works for me.