QTableView int32_t overflow workaround#2801
Merged
mgrojo merged 4 commits intosqlitebrowser:masterfrom Sep 6, 2023
sandman7920:master
Merged
QTableView int32_t overflow workaround#2801mgrojo merged 4 commits intosqlitebrowser:masterfrom sandman7920:master
mgrojo merged 4 commits intosqlitebrowser:masterfrom
sandman7920:master
Conversation
This was implemented as a workaround for #2592 and #2787. There is an issue with QTableView integer overflow (int32_t), when QTableView::defaultRowSize() = 30, maximum number of rows which can be rendered is 0x7fffffff / 30 = 71,582,788. When a huge SQLite table is selected in the BrowserTab, DB4S hangs in an infinite render loop. More info #2592 (comment)
The value is not visible in the Preferences dialog, but can be overwritten from the command line.
Member
|
Thank you very much for this, @sandman7920! I haven't had the chance to review this in detail yet. But two general thoughts from my side:
|
Contributor
Author
Yes, we could, but if the user resizes only one row, we are in the same position. |
Contributor
Author
Member
|
Yes, something like that makes sense too. |
d396227 to
16035be
Compare
mgrojo
approved these changes
Feb 13, 2022
Member
mgrojo
left a comment
There was a problem hiding this comment.
I consider this ready to merge. I'll do it in some days, if there are no objections.
4bc0c36 to
e0a000c
Compare
Member
|
Let's merge this. Nobody objected after more days than I initially thought were going to pass. 😄 Sorry for the long delay. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Workaround for #2592 and #2787