settings: Specify a default databrowser font#3348
Merged
justinclift merged 1 commit intosqlitebrowser:masterfrom May 23, 2023
Coderlane:fonts
Merged
settings: Specify a default databrowser font#3348justinclift merged 1 commit intosqlitebrowser:masterfrom Coderlane:fonts
justinclift merged 1 commit intosqlitebrowser:masterfrom
Coderlane:fonts
Conversation
This copies the default font from `editor/font` below for `databrowser/font`. Fixes #3296
Member
|
@scottfurry would be interested* in this, to add to his 'fix settings' project... :) *or not... ;) |
Contributor
|
@chrisjlocke - I saw the discussion leading up to this. I'm slowly digging out other defaults. The pull seems like a prudent fix. I would recommend proceeding with this effort. |
Member
|
Should this be merged (after running CI), or is it still being worked on, or ? |
Contributor
|
@justinclift - I would recommend merge. It can be pulled out, if necessary, at a later date. |
Member
|
Cool, done. 😄 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies the default font from
editor/fontbelow fordatabrowser/font. Leaving this unset causes odd font issues on macOS when the unset value is read back in.Fixes #3296