BUILD_VERSION de-duplication#3405
Merged
justinclift merged 1 commit intosqlitebrowser:masterfrom Jul 13, 2023
scottfurry:BuildVersion
Merged
BUILD_VERSION de-duplication#3405justinclift merged 1 commit intosqlitebrowser:masterfrom scottfurry:BuildVersion
justinclift merged 1 commit intosqlitebrowser:masterfrom
scottfurry:BuildVersion
Conversation
CMake process to determine BUILD_VERSION value is made twice in CMakeLists.txt. Deplicated text is removed and step is moved to a more logical placement. ::w:
Member
|
Cool, looks good to me. 😄 |
Contributor
Author
|
Thanks, @justinclift |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake process to determine BUILD_VERSION value is made twice in CMakeLists.txt. Duplicated text is removed and step is moved to a more logical placement.