Skip to content

Replace archived rubex by src-d/go-oniguruma#206

Merged
bzz merged 1 commit intosrc-d:masterfrom
kuba--:go-mod
Mar 15, 2019
Merged

Replace archived rubex by src-d/go-oniguruma#206
bzz merged 1 commit intosrc-d:masterfrom
kuba--:go-mod

Conversation

@kuba--
Copy link

@kuba-- kuba-- commented Mar 14, 2019

Signed-off-by: kuba-- [email protected]

@kuba-- kuba-- changed the title Add support for go modules Add support for go modules and replace archived rubex by src-d/go-oniguruma Mar 14, 2019
@kuba-- kuba-- changed the title Add support for go modules and replace archived rubex by src-d/go-oniguruma Replace archived rubex by src-d/go-oniguruma Mar 14, 2019
@dennwc dennwc requested a review from bzz March 14, 2019 15:46
Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I belive it's also worth mentioning in PR description that this addresses #203

@kuba-- do we expect any performance implications that would make it worth to re-run the benchmark?

@kuba--
Copy link
Author

kuba-- commented Mar 15, 2019

@bzz - there is no much changes in library itself. The only reasons why I forked rubex to src-d/go-oniguruma:

  • rubex is not in development, anymore (archived) so no prs etc.
  • I wanted to suppress compilation warning.
  • get rid of all not needed stuff and 2K+ tags

So, technically speaking nothing has been changed in terms of performance, workflow etc.

Copy link
Contributor

@bzz bzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch and kind explanation @kuba-- !

@bzz bzz merged commit 56214e3 into src-d:master Mar 15, 2019
@kuba-- kuba-- deleted the go-mod branch March 15, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants