Don't return error from github provider on push event#372
Merged
smacker merged 1 commit intosrc-d:masterfrom Dec 3, 2018
smacker:dont_return_error_on_push_post
Merged
Don't return error from github provider on push event#372smacker merged 1 commit intosrc-d:masterfrom smacker:dont_return_error_on_push_post
smacker merged 1 commit intosrc-d:masterfrom
smacker:dont_return_error_on_push_post
Conversation
Currently we pollute logs with such "errors". But it's not really an error we don't post anything on push by current design (focus only on review and don't accomodate other github APIs). Signed-off-by: Maxim Sukharev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we pollute logs with such "errors".
But it's not really an error we don't post anything on push by current design
(focus only on review and don't accommodate other github APIs).
Signed-off-by: Maxim Sukharev [email protected]