SIP10 addition: add spec for memo#25
Closed
lgalabru wants to merge 3 commits intostacksgov:hstove-feat/sip-10-ftfrom
Closed
SIP10 addition: add spec for memo#25lgalabru wants to merge 3 commits intostacksgov:hstove-feat/sip-10-ftfrom
lgalabru wants to merge 3 commits intostacksgov:hstove-feat/sip-10-ftfrom
Conversation
This was referenced May 13, 2021
Merged
Contributor
|
@jcnelson this PR is a bit off because the SIP repo branch for |
Co-authored-by: Hank Stoever <[email protected]>
Contributor
Author
Contributor
Contributor
|
Maybe a miscommunication - what I meant is that this PR is trying to merge into the Either way, it's all good - I've cherry-picked and pushed @lgalabru's commits to #5. So, I think we can close this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a proposal for augmenting the transfer function with an optional memo field.
I'd also recommend going with a naming more explicit for this trait - something like
sip-010-traitwould be more descriptive: this trait is the first, but we will probably see other kind of fungible token in the future.