Skip to content

Issue/1029 record fixed param as override#1286

Closed
mitzimorris wants to merge 3 commits intodevelopfrom
issue/1029-record-fixed-param-as-override
Closed

Issue/1029 record fixed param as override#1286
mitzimorris wants to merge 3 commits intodevelopfrom
issue/1029-record-fixed-param-as-override

Conversation

@mitzimorris
Copy link
Member

@mitzimorris mitzimorris commented Jul 23, 2024

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Add logic to the write_config method to record when fixed_param sampler is used.

Intended Effect:

Make it easy to identify StanCSV output files produced by sampler algorithm fixed_param, both by humans as well as by stan_csv_reader.

How to Verify:

Unit tests.

Side Effects:

N/A

Documentation:

N/A

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris mitzimorris requested a review from WardBrian July 23, 2024 20:07
@mitzimorris mitzimorris mentioned this pull request Jul 23, 2024
Closed
3 tasks
@stan-buildbot
Copy link
Contributor

stan-buildbot commented Jul 23, 2024

Name Old Result New Result Ratio Performance change( 1 - new / old )
arma/arma.stan 0.33 0.32 1.03 2.85% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.01 0.01 0.96 -4.56% slower
gp_regr/gen_gp_data.stan 0.02 0.02 1.01 0.88% faster
gp_regr/gp_regr.stan 0.1 0.1 1.04 3.44% faster
sir/sir.stan 70.79 72.79 0.97 -2.81% slower
irt_2pl/irt_2pl.stan 4.21 4.28 0.98 -1.82% slower
eight_schools/eight_schools.stan 0.06 0.06 1.01 1.06% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.25 0.25 1.0 0.4% faster
pkpd/one_comp_mm_elim_abs.stan 20.21 20.1 1.01 0.54% faster
garch/garch.stan 0.44 0.44 1.01 1.03% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.76 2.77 1.0 -0.22% slower
arK/arK.stan 1.84 1.83 1.01 0.83% faster
gp_pois_regr/gp_pois_regr.stan 2.88 2.92 0.99 -1.32% slower
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.86 8.87 1.0 -0.14% slower
performance.compilation 191.84 184.32 1.04 3.92% faster
Mean result: 1.00319682574808

Jenkins Console Log
Blue Ocean
Commit hash: c83a397be67c59ba135871db25c53717e78d796e

Machine information No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focal

CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 48 bits virtual
CPU(s): 80
On-line CPU(s) list: 0-79
Thread(s) per core: 2
Core(s) per socket: 20
Socket(s): 2
NUMA node(s): 2
Vendor ID: GenuineIntel
CPU family: 6
Model: 85
Model name: Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz
Stepping: 4
CPU MHz: 2400.000
CPU max MHz: 3700.0000
CPU min MHz: 1000.0000
BogoMIPS: 4800.00
Virtualization: VT-x
L1d cache: 1.3 MiB
L1i cache: 1.3 MiB
L2 cache: 40 MiB
L3 cache: 55 MiB
NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78
NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: KVM: Mitigation: VMX disabled
Vulnerability L1tf: Mitigation; PTE Inversion; VMX conditional cache flushes, SMT vulnerable
Vulnerability Mds: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Meltdown: Mitigation; PTI
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Mitigation; IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; IBRS, IBPB conditional, STIBP conditional, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Mitigation; Clear CPU buffers; SMT vulnerable
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti intel_ppin ssbd mba ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku ospke md_clear flush_l1d arch_capabilities

G++:
g++ (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Clang:
clang version 10.0.0-4ubuntu1
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin

@WardBrian
Copy link
Member

WardBrian commented Jul 24, 2024

@nhuurre before looking at this I wanted to ask if you thought we had any chance of merging something like #1054 instead and removing this fixed_param behavior, or should we continue to hack around it?

@mitzimorris
Copy link
Member Author

mitzimorris commented Jul 24, 2024

if we could do something like #1054, then we wouldn't need to do stan-dev/stan#3302 either.

@nhuurre
Copy link

nhuurre commented Jul 24, 2024

#1054 requires stan-dev/stan#3071 . The only reason that was blocked is that Michael (betanalpha) thinks zero-dimensional spaces are one-dimensional. I have no intention of continuing to argue with him.

I haven't seen him on github or the Stan Forums for a year or two now so I suppose we'd need someone else to review the pull request anyway. If you want me to argue about HMC and zero-dimensional topology with that someone else -- yes, I can do that.

@WardBrian
Copy link
Member

WardBrian commented Jul 24, 2024

I believe the pull request was already approved, and I just took a look at it again and it seems fine, so perhaps that is the way to go

@WardBrian
Copy link
Member

WardBrian commented Jul 31, 2024

At this point we should replace this with a newer version of #1054, right?

@WardBrian WardBrian mentioned this pull request Aug 5, 2024
Merged
2 tasks
@WardBrian WardBrian deleted the issue/1029-record-fixed-param-as-override branch September 30, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WardBrian WardBrian Awaiting requested review from WardBrian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mitzimorris @stan-buildbot @WardBrian @nhuurre